As a Domino Developer, I'm used to mostly working alone. Sure, I've worked in large teams before, but in those cases I was usually the only Developer, with the rest of the team members being architects / admins / deadwood (management). At the moment however, I'm working on a large ASP.NET project in a "team". After a morning of fixing "someone elses" inability to spell properly, I'm missing that. How many different ways can you misspell "Correspondence" inside a SINGLE PIECE OF CODE. The word is used throughout all parts of the application, however the crap below was found in a single location.
Inside the code, which in this case happens to be the code behind an aspx page (a cs file), there are a couple of instances where the word is spelt correctly. A quick count of all instances (now that I've fixed them all) shows that the word is used either by itself as a variable, as part of a variable, or as part of a label for a total of 17 times.
First one we have is a property of the main class called isCorrespodence. This was used about 3 times - easy to fix, but it's used in a few places, so it's a bit painful, but no dramas. This property is a string representation of the actual data, which happens to be boolean. This means you can end up with the amusing code below;
public string Correspodence
{
get { return (isCorrespondence ? "Y" : "-"); }
}
The 'Correspodence' string is referenced in a couple of places, and of course derives it's value from the isCorrespondence bool. Nice huh. You have the variable names right next to each other and still can't get it right - it's lazy. Is he dyslexic? No, he's not - a dyslexic person wouldn't make this mistake, at least none of the dyslexic people I've worked with would. Know why? Because they've spent a lot of time working out how to deal with their dyslexia, they'd use simple tips, like copying and pasting the complex part of the word and changing the prefix, or using a site such as dictionary.com or a Word spellchecker.
So, what's next? well we have this text appearing in a label:
type = "Home and Corresondence";
Corresondence could be a simple typo. It's pretty easy to leave a letter out of a word, and I guess it's a bit more excusable in the case of a label when you don't have a syntax checker to do some hard work for you. However, in the full context of where it's used, you can see it's more laziness, as it's used right next to our friend isCorrespondence which is spelt correctly:
if (isHome && isCorrespondence)
type = "Home and Corresondence";
Yeah this one wasn't hard to modify obviously, but compounded it was kind of frustrating.
Finally we have a case of phonetics;
public bool IsCurrectAddress
That's obviously not the currect (!) spelling. No big deal, but tbh, I've got better things to do than act as a spellchecker for the code of people who are apparently "Senior" Developers. Part of being a Senior developer should be, imo, developing code which is quality in all aspects - part of that is consistent naming of variables. You don't have to be able to win a spelling competition here, just use some logic. You've used the word a few times in this code block already, so reuse it. Or compare the spellings and see if they're identical. The code behind file here I'm referencing is pretty small, those 17 lines where the word "Correspondence" occurs probably equate to 2-5% of the entire thing, At least if you spell it incorrectly CONSISTENTLY throughout the entire file then I can do a simple replace all in order to fix it for you, right?
The worst thing is, I could probably develop an entire site in the style of George's tickets to this guy.. and he'll probably never get fired..